tests: Skip TLS profile change test when is executed on Hosted clusters by fjglira · Pull Request #1873 · istio-ecosystem/sail-operator

fjglira · 2026-04-23T12:48:22Z

There are failures when the test is executed on hosted cluster because by default changing the TLS profile

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

There are failures when the test is executed on hosted cluster because by default changing the TLS profile Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Adding comment to let folks to know the reason of the skip Signed-off-by: Francisco Herrera <fjglira@gmail.com>

fjglira · 2026-04-23T12:50:29Z

THe test was just added on main, so we are not going to cherry-pick this change

codecov · 2026-04-23T12:54:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.20%. Comparing base (fe232ca) to head (22fb5b0).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (fe232ca) and HEAD (22fb5b0). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (fe232ca) HEAD (22fb5b0)

integration-tests 1 0

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1873       +/-   ##
===========================================
- Coverage   73.88%   51.20%   -22.68%     
===========================================
  Files          51       51               
  Lines        3224     3224               
===========================================
- Hits         2382     1651      -731     
- Misses        719     1488      +769     
+ Partials      123       85       -38

Flag	Coverage Δ
integration-tests	`?`
unit-tests	`51.20% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* upstream/main: (31 commits) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1850) Add documentation for resource customization (istio-ecosystem#1292) refactor error and status condition handling (istio-ecosystem#1807) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1848) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1845) feat: add targetRef field to ZTunnel CRD (istio-ecosystem#1259) Add 1.29.2 and 1.28.6 versions (istio-ecosystem#1844) Use typed Go structs for FIPS values instead of helm.Values (istio-ecosystem#1695) ...

* upstream/main: (35 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1850) Add documentation for resource customization (istio-ecosystem#1292) refactor error and status condition handling (istio-ecosystem#1807) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1848) ...

* upstream/main: (39 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1896) Fix test docs test failure (istio-ecosystem#1890) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1892) Skip processing aliases referencing pre-released versions in EOL updater (istio-ecosystem#1883) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) ...

* upstream/main: (41 commits) fix: handle repos with different release branch naming in crd-schema-checker (istio-ecosystem#1897) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1899) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1896) Fix test docs test failure (istio-ecosystem#1890) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1892) Skip processing aliases referencing pre-released versions in EOL updater (istio-ecosystem#1883) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) ...

…rs (istio-ecosystem#1873) * tests: Skip TLS profile change test when is executed on Hosted clusters There are failures when the test is executed on hosted cluster because by default changing the TLS profile Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Adding comment Adding comment to let folks to know the reason of the skip Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* OSSM 3.4 product changes - Makefile.vendor.mk - ossm/merge_upstream.sh - ossm/values.yaml - pkg/istioversion/versions.ossm.yaml - `make gen` output * e2e Test for Integration OSSM and Cert Manager in Sail Operator * Set empty vendor defaults for integration tests Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Increase mem limit of sail operator (#433) Upstream change for a reference - istio-ecosystem#1104 * Add istioctl consoleclidownload (#130) * Add istioctl consoleclidownload and install instructions Signed-off-by: bmangoen <bmangoen@redhat.com> * Modify the download URL Signed-off-by: bmangoen <bmangoen@redhat.com> * Fill supported commands table Signed-off-by: bmangoen <bmangoen@redhat.com> * Fix install procedure Signed-off-by: bmangoen <bmangoen@redhat.com> * Remove istioctl install doc Signed-off-by: bmangoen <bmangoen@redhat.com> * Add explanation for consoleclidownload Signed-off-by: bmangoen <bmangoen@redhat.com> --------- Signed-off-by: bmangoen <bmangoen@redhat.com> * Fix cert manager test Cert manager test is not available upstream so we need to apply changes to common funtions manually. * Removing workaround for OCPBUGS-56758 (#485) The bug is fixed, the workaround is no longer needed * Do not remove servicemeshoperator3.clusterserviceversion.yaml when (#757) (#758) merging upstream changes. We can't remove servicemeshoperator3.clusterserviceversion.yaml as it's embedded in bundle/bundle.go and mirror-licenses make target fails if it's missing Breaking change was introduced in #721 Signed-off-by: Filip Brychta <fbrychta@redhat.com> * Fix 3.4 operator manifest * Add istio v1.30-latest and 1.30.0 * Add 1.28.7 istio version and resources * Update vendor_defaults for 3.4 release * Remove gateway API workaround from Istio 1.28.4+ and 1.27.8+ * Restore EnsureNamespace function Restore EnsureNamespace function. The function was removed in 9fba17d but is needed by TLS adherence tests added in 1b879c5. * Add v1.26 EOL versions to maintain API compatibility Add v1.26.* as EOL entries in versions.ossm.yaml to prevent breaking changes from OSSM 3.3. These versions remain valid enum values but are not installable, following upstream pattern. Regenerate CRDs to pass schema compatibility validation. * tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) * tests: Skip TLS profile change test when is executed on Hosted clusters There are failures when the test is executed on hosted cluster because by default changing the TLS profile Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Adding comment Adding comment to let folks to know the reason of the skip Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> * enable cert-manager test when ambient mode is enabled * Run cert-manager test with ambient mode enabled (#660) * cert-manager operator removal process improvements * [release-1.28] test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1878) * test: Modify await_operator to dinamically get deployment name from csv when OLM is true If bundle name is different to sail operator and OLM is set to true in the test we got failures because await_operator never find a sail-operator deployment in the namespace Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Get the deployment name from current .clusterserviceversion.yaml file in the manifest/bundle folder Changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com> * Set DEPLOYMENT_NAME to csv name when OLM is true (istio-ecosystem#1922) This will avoid issues on the test while waiting for operator because will set DEPLOYMENT_NAME to the csv name used into fork test Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com> * tests: Skip flaky TLS adherence test causing OOM The 'syncs TLS settings when TLSAdherence is set to StrictAllComponents' test causes OOM due to multiple operator restarts triggered by APIServer updates. Additionally, the test has nil pointer panics when accessing rev.Spec.Values.Pilot.ExtraContainerArgs on line 380. Skipping until the test is stabilized with proper timeouts and nil checks. --------- Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> Signed-off-by: Filip Brychta <fbrychta@redhat.com> Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: ctartici <ctartici@redhat.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Filip Brychta <fbrychta@redhat.com> Co-authored-by: Brian Mangoenpawiro <bmangoen@gmail.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Istio Automation <istio-testing-bot@google.com>

tests: Skip TLS profile change test when is executed on Hosted clusters

bb21061

There are failures when the test is executed on hosted cluster because by default changing the TLS profile Signed-off-by: Francisco Herrera <fjglira@gmail.com>

fjglira requested a review from a team as a code owner April 23, 2026 12:48

istio-testing added the size/XS label Apr 23, 2026

Adding comment

22fb5b0

Adding comment to let folks to know the reason of the skip Signed-off-by: Francisco Herrera <fjglira@gmail.com>

istio-testing added size/S and removed size/XS labels Apr 23, 2026

mkralik3 approved these changes Apr 23, 2026

View reviewed changes

istio-testing merged commit d82d87d into istio-ecosystem:main Apr 23, 2026
15 of 17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: Skip TLS profile change test when is executed on Hosted clusters#1873

tests: Skip TLS profile change test when is executed on Hosted clusters#1873
istio-testing merged 2 commits into
istio-ecosystem:mainfrom
fjglira:fix-tls-test

fjglira commented Apr 23, 2026

Uh oh!

fjglira commented Apr 23, 2026

Uh oh!

codecov Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

fjglira commented Apr 23, 2026

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Additional information:

Uh oh!

fjglira commented Apr 23, 2026

Uh oh!

codecov Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Apr 23, 2026 •

edited

Loading